[ui] Add Validation for Save file path accessibility #2625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessibility method helps identify whether a given save path directory is accessible for the user to write to.
File and template save as validation includes an access check to ensure that a given directory exists and the user has access for writing to it
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2625 +/- ##
========================================
Coverage 69.90% 69.90%
========================================
Files 121 121
Lines 7078 7078
========================================
Hits 4948 4948
Misses 2130 2130 ☔ View full report in Codecov by Sentry. |
cbentejac
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a validation check to enhance the user experience by showing a warning popup when saving a file/template to a directory which is either not present or is not accessible to the user for writing to it.
Features list
Implementation remarks
Added an
accessiblehelper to validate whether a given directory to save to is accessible for the user.Updated the common
validateFilepathForSavefunction to ensure the user has permission to save to the provided path.This works in two ways, if either the directory the user is trying to save to does not exist it will return false, and the warning dialog shows up, or in case the user does not have access to writing to the directory also prompts the warning dialog.